Skip to content

Commit fc2c456

Browse files
PhilipYangAalexdeucher
authored andcommitted
drm/amdkfd: set "r = 0" explicitly before goto
To silence the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2615 svm_range_restore_pages() warn: missing error code here? 'get_task_mm()' failed. 'r' = '0' Signed-off-by: Philip Yang <[email protected]> Suggested-by: Dan Carpenter <[email protected]> Reviewed-by: Felix Kuehling <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent c9beecc commit fc2c456

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/gpu/drm/amd/amdkfd/kfd_svm.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2614,6 +2614,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,
26142614

26152615
if (atomic_read(&svms->drain_pagefaults)) {
26162616
pr_debug("draining retry fault, drop fault 0x%llx\n", addr);
2617+
r = 0;
26172618
goto out;
26182619
}
26192620

@@ -2623,6 +2624,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,
26232624
mm = get_task_mm(p->lead_thread);
26242625
if (!mm) {
26252626
pr_debug("svms 0x%p failed to get mm\n", svms);
2627+
r = 0;
26262628
goto out;
26272629
}
26282630

@@ -2660,6 +2662,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,
26602662

26612663
if (svm_range_skip_recover(prange)) {
26622664
amdgpu_gmc_filter_faults_remove(adev, addr, pasid);
2665+
r = 0;
26632666
goto out_unlock_range;
26642667
}
26652668

@@ -2668,6 +2671,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,
26682671
if (timestamp < AMDGPU_SVM_RANGE_RETRY_FAULT_PENDING) {
26692672
pr_debug("svms 0x%p [0x%lx %lx] already restored\n",
26702673
svms, prange->start, prange->last);
2674+
r = 0;
26712675
goto out_unlock_range;
26722676
}
26732677

0 commit comments

Comments
 (0)