Skip to content

Commit bc440a9

Browse files
njhollinghurstpopcornmix
authored andcommitted
drm: Add RP1 DPI driver
Add support for the RP1 DPI hardware. Signed-off-by: Nick Hollinghurst <[email protected]> drm/rp1: depends on, instead of select, MFD_RP1 According to kconfig-language.txt [1], select should be used only for "non-visible symbols ... and for symbols with no dependencies". Since MFD_RP1 both is visible and has a dependency, "select" should not be used and "depends on" should be used instead. In particular, this fixes the build of this kernel tree on NixOS, where its kernel config system will try to answer 'M' to as many config as possible. [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html Signed-off-by: Ratchanan Srirattanamet <[email protected]> drm: rp1: VEC and DPI drivers: Fix bug #5901 Rework probe() to use devm_drm_dev_alloc(), embedding the DRM device in the DPI or VEC device as now seems to be recommended. Change order of resource allocation and driver initialization. This prevents it trying to write to an unmapped register during clean-up, which previously could crash. Signed-off-by: Nick Hollinghurst <[email protected]>
1 parent 5b3ab08 commit bc440a9

File tree

6 files changed

+1496
-0
lines changed

6 files changed

+1496
-0
lines changed

drivers/gpu/drm/rp1/rp1-dpi/Kconfig

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# SPDX-License-Identifier: GPL-2.0-only
2+
config DRM_RP1_DPI
3+
tristate "DRM Support for RP1 DPI"
4+
depends on DRM && MFD_RP1
5+
select DRM_GEM_DMA_HELPER
6+
select DRM_KMS_HELPER
7+
select DRM_VRAM_HELPER
8+
select DRM_TTM
9+
select DRM_TTM_HELPER
10+
help
11+
Choose this option to enable Video Out on RP1

drivers/gpu/drm/rp1/rp1-dpi/Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# SPDX-License-Identifier: GPL-2.0-only
2+
3+
drm-rp1-dpi-y := rp1_dpi.o rp1_dpi_hw.o rp1_dpi_cfg.o
4+
5+
obj-$(CONFIG_DRM_RP1_DPI) += drm-rp1-dpi.o

0 commit comments

Comments
 (0)