Skip to content

Commit b67b796

Browse files
arndbSasha Levin
authored and
Sasha Levin
committed
cpufreq: qcom-hw: add CONFIG_COMMON_CLK dependency
[ Upstream commit 3093fa3 ] It is still possible to compile-test a kernel without CONFIG_COMMON_CLK for some ancient ARM boards or other architectures, but this causes a link failure in the qcom-cpufreq-hw driver: ERROR: modpost: "devm_clk_hw_register" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! ERROR: modpost: "of_clk_hw_onecell_get" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! Add a Kconfig dependency here to make sure this always work. Apparently this bug has been in the kernel for a while without me running into it on randconfig builds as COMMON_CLK is almost always enabled. I have cross-checked by building an allmodconfig kernel with COMMON_CLK disabled, which showed no other driver having this problem. Fixes: 4370232 ("cpufreq: qcom-hw: Add CPU clock provider support") Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Viresh Kumar <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 4a1d55b commit b67b796

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/cpufreq/Kconfig.arm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ config ARM_QCOM_CPUFREQ_NVMEM
173173
config ARM_QCOM_CPUFREQ_HW
174174
tristate "QCOM CPUFreq HW driver"
175175
depends on ARCH_QCOM || COMPILE_TEST
176+
depends on COMMON_CLK
176177
help
177178
Support for the CPUFreq HW driver.
178179
Some QCOM chipsets have a HW engine to offload the steps

0 commit comments

Comments
 (0)