Skip to content

Commit a535fff

Browse files
author
Phil Elwell
committed
spidev: Completely disable the DT warning
The upstream SPI and DT maintainers are completely opposed to declaring in Device Tree that an SPI CS line is to be managed by the spidev driver, even though the facility is useful on a hobbyist device like a Raspberry Pi where arbitrary devices can be attached, and the alternative to DT declaration (spi_board_info) has been almost entirely rendered obsolete by DT. Continue to override their objections by disabling the warning. See: #3361 #1054 Signed-off-by: Phil Elwell <[email protected]>
1 parent 2eb5f28 commit a535fff

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/spi/spidev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -724,6 +724,7 @@ static int spidev_probe(struct spi_device *spi)
724724
* compatible string, it is a Linux implementation thing
725725
* rather than a description of the hardware.
726726
*/
727+
if (0) /* Disable the warning - this feature is too useful */
727728
WARN(spi->dev.of_node &&
728729
of_device_is_compatible(spi->dev.of_node, "spidev"),
729730
"%pOF: buggy DT: spidev listed directly in DT\n", spi->dev.of_node);

0 commit comments

Comments
 (0)