Skip to content

Commit 893dc68

Browse files
lwfingerKalle Valo
authored and
Kalle Valo
committed
rtlwifi: Fix scheduling while atomic splat
Following commit cceb0a5 ("rtlwifi: Add work queue for c2h cmd."), the following BUG is reported when rtl8723be is used: BUG: sleeping function called from invalid context at mm/slab.h:432 in_atomic(): 1, irqs_disabled(): 1, pid: 0, name: swapper/0 CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W O 4.11.0-rc3-wl+ #276 Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.50 09/29/2014 Call Trace: <IRQ> dump_stack+0x63/0x89 ___might_sleep+0xe9/0x130 __might_sleep+0x4a/0x90 kmem_cache_alloc_trace+0x19f/0x200 ? rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi] rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi] rtl8723be_c2h_packet_handler+0xac/0xc0 [rtl8723be] rtl8723be_rx_command_packet+0x37/0x5c [rtl8723be] _rtl_pci_rx_interrupt+0x200/0x6b0 [rtl_pci] _rtl_pci_interrupt+0x20c/0x5d0 [rtl_pci] __handle_irq_event_percpu+0x3f/0x1d0 handle_irq_event_percpu+0x23/0x60 handle_irq_event+0x3c/0x60 handle_fasteoi_irq+0xa2/0x170 handle_irq+0x20/0x30 do_IRQ+0x48/0xd0 common_interrupt+0x89/0x89 ... Although commit cceb0a5 converted most c2h commands to use a work queue, the Bluetooth coexistence routines can be in atomic mode when they execute such a call. Fixes: cceb0a5 ("rtlwifi: Add work queue for c2h cmd.") Signed-off-by: Larry Finger <[email protected]> Cc: Ping-Ke Shih <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
1 parent d8a531c commit 893dc68

File tree

1 file changed

+4
-2
lines changed
  • drivers/net/wireless/realtek/rtlwifi

1 file changed

+4
-2
lines changed

drivers/net/wireless/realtek/rtlwifi/base.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,12 +1742,14 @@ void rtl_c2hcmd_enqueue(struct ieee80211_hw *hw, u8 tag, u8 len, u8 *val)
17421742
unsigned long flags;
17431743
struct rtl_c2hcmd *c2hcmd;
17441744

1745-
c2hcmd = kmalloc(sizeof(*c2hcmd), GFP_KERNEL);
1745+
c2hcmd = kmalloc(sizeof(*c2hcmd),
1746+
in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
17461747

17471748
if (!c2hcmd)
17481749
goto label_err;
17491750

1750-
c2hcmd->val = kmalloc(len, GFP_KERNEL);
1751+
c2hcmd->val = kmalloc(len,
1752+
in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
17511753

17521754
if (!c2hcmd->val)
17531755
goto label_err2;

0 commit comments

Comments
 (0)