Skip to content

Commit 3f8dec1

Browse files
dvhartrafaeljw
authored andcommitted
ACPI/APEI: Limit printable size of BERT table data
Platforms with large BERT table data can trigger soft lockup errors while attempting to print the entire BERT table data to the console at boot: watchdog: BUG: soft lockup - CPU#160 stuck for 23s! [swapper/0:1] Observed on Ampere Altra systems with a single BERT record of ~250KB. The original bert driver appears to have assumed relatively small table data. Since it is impractical to reassemble large table data from interwoven console messages, and the table data is available in /sys/firmware/acpi/tables/data/BERT limit the size for tables printed to the console to 1024 (for no reason other than it seemed like a good place to kick off the discussion, would appreciate feedback from existing users in terms of what size would maintain their current usage model). Alternatively, we could make printing a CONFIG option, use the bert_disable boot arg (or something similar), or use a debug log level. However, all those solutions require extra steps or change the existing behavior for small table data. Limiting the size preserves existing behavior on existing platforms with small table data, and eliminates the soft lockups for platforms with large table data, while still making it available. Signed-off-by: Darren Hart <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent f3303ff commit 3f8dec1

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/acpi/apei/bert.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
#undef pr_fmt
3131
#define pr_fmt(fmt) "BERT: " fmt
32+
#define ACPI_BERT_PRINT_MAX_LEN 1024
3233

3334
static int bert_disable;
3435

@@ -58,8 +59,11 @@ static void __init bert_print_all(struct acpi_bert_region *region,
5859
}
5960

6061
pr_info_once("Error records from previous boot:\n");
61-
62-
cper_estatus_print(KERN_INFO HW_ERR, estatus);
62+
if (region_len < ACPI_BERT_PRINT_MAX_LEN)
63+
cper_estatus_print(KERN_INFO HW_ERR, estatus);
64+
else
65+
pr_info_once("Max print length exceeded, table data is available at:\n"
66+
"/sys/firmware/acpi/tables/data/BERT");
6367

6468
/*
6569
* Because the boot error source is "one-time polled" type,

0 commit comments

Comments
 (0)