Skip to content

Commit 269ebce

Browse files
Dongli Zhangdavem330
Dongli Zhang
authored andcommitted
xen-netfront: cast grant table reference first to type int
IS_ERR_VALUE() in commit 87557ef ("xen-netfront: do not cast grant table reference to signed short") would not return true for error code unless we cast ref first to type int. Signed-off-by: Dongli Zhang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4fd19c1 commit 269ebce

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/xen-netfront.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ static void xennet_alloc_rx_buffers(struct netfront_queue *queue)
304304
queue->rx_skbs[id] = skb;
305305

306306
ref = gnttab_claim_grant_reference(&queue->gref_rx_head);
307-
WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)ref));
307+
WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)(int)ref));
308308
queue->grant_rx_ref[id] = ref;
309309

310310
page = skb_frag_page(&skb_shinfo(skb)->frags[0]);
@@ -428,7 +428,7 @@ static void xennet_tx_setup_grant(unsigned long gfn, unsigned int offset,
428428
id = get_id_from_freelist(&queue->tx_skb_freelist, queue->tx_skbs);
429429
tx = RING_GET_REQUEST(&queue->tx, queue->tx.req_prod_pvt++);
430430
ref = gnttab_claim_grant_reference(&queue->gref_tx_head);
431-
WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)ref));
431+
WARN_ON_ONCE(IS_ERR_VALUE((unsigned long)(int)ref));
432432

433433
gnttab_grant_foreign_access_ref(ref, queue->info->xbdev->otherend_id,
434434
gfn, GNTMAP_readonly);

0 commit comments

Comments
 (0)