Add dedicated exception for basic.return messages.
#1832
Conversation
Fixes #1831 This PR adds the `PublishReturnException` class that includes the originating exchange and routing key for a `basic.return` message. It should be backwards-compatible in the API.
|
While it's good to add these properties to the exception for inspection, I'd also really like to see exception messages being added that display these property values in the message text. Those messages tend to get logged along with stack traces and provide useful information in logs. Custom properties on an exception are much less likely to make it into a log file. |
|
@SzymonPobiega and @Gsantomaggio all set for a re-review, thanks. |
Feel free to suggest a patch! Or, modify my PR directly @bording ... I think you have write access here 😸 |
bording
force-pushed
the
rabbitmq-dotnet-client-1831
branch
from
4a64a83 to
39397a6
Compare
bording
force-pushed
the
rabbitmq-dotnet-client-1831
branch
from
39397a6 to
5b62dff
Compare
I pushed up a change to add exception messages. The interesting one is for the return messages because there really isn't any useful information to include for a nack. |
Fixes #1831
This PR adds the
PublishReturnExceptionclass that includes the originating exchange and routing key for abasic.returnmessage. It should be backwards-compatible in the API.