Merge when 🤖 automerge label is applied, if checks already passed

[encukou]

I've applied the 🤖 automerge label to an issue whose checks already passed, and was a bit surprised that nothing happened. I had to press Squash and add GH- by hand! (I admit I am very spoiled by useful bots.)

Would it be a good idea automerge when the label is added, if the other conditions are met?

[Mariatta]

GitMate.io thinks possibly related issues are python/core-workflow#267 (Automatically apply "needs backport to " labels.), #131 (Error when trying to merge a PR that's already merged), python/core-workflow#29 (Automatically merge with passing tests and a +1 Review), python/core-workflow#278 (Add 'skip backport' label to skip the backport source check.), and python/core-workflow#27 (Merge commit messages).

[Mariatta]

The rule is:

• it has 🤖 automerge label
• it has awaiting merge label
• all CI passed

It sounds like the awaiting merge label was missing from your PR?

I think having the "awaiting merge" label is important, it signifies that a core developer has approved the PR. If you approved the PR, then it would have automerged.

[Mariatta]

Closing this issue. The automerge works as intended. I believe it was just missing the "awaiting merge" label in the case you described, which gets added it you approved it.