Skip to content

Add linkcheck to CI #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
levlaz opened this issue Nov 1, 2017 · 4 comments
Closed

Add linkcheck to CI #292

levlaz opened this issue Nov 1, 2017 · 4 comments

Comments

@levlaz
Copy link
Contributor

levlaz commented Nov 1, 2017

I noticed a TODO in the .travis.yml file to add linkcheck to CI.

This is simple enough to do, is there a historical reason why it has not been done?

@zware
Copy link
Member

zware commented Nov 1, 2017

I suspect it's just the fact that it would be failing, or take significant time to run. It would be worth a PR to turn it on and see what it does, but there's no guarantee that we'd merge it yet.

@levlaz
Copy link
Contributor Author

levlaz commented Nov 2, 2017

It might be useful to run the report on each build (and not cause the build to "fail") and save it as an artifact for handy reference.

It seems that in order to use artifacts on travis you need to upload them to S3 manually. Which seems not ideal.

Would you be opposed to switching to CircleCI? They host artifacts for free.

Disclaimer: I work at CircleCI. :)

This was referenced Nov 2, 2017
@willingc
Copy link
Collaborator

Next action: Enable linkcheck on travis as a test. Mark this test as Failure OK so that it does not prevent merges yet provides information to contributors.

@hugovk
Copy link
Member

hugovk commented May 15, 2018

Please see PR #369.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants