From 507d2119907264987f37156155a8d23b371530fe Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 26 Oct 2022 16:15:39 +0300 Subject: [PATCH] gh-98713: Use `@cpython_only` for a test that fails on PyPy (GH-98714) Co-authored-by: Alex Waygood (cherry picked from commit 9495360c7256938a6185838561cf416599b7e94f) Co-authored-by: Nikita Sobolev --- Lib/test/test_typing.py | 3 ++- .../next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 7c48c869ad4f81..50fe679c6a31d9 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -42,7 +42,7 @@ import weakref import types -from test.support import import_helper, captured_stderr +from test.support import import_helper, captured_stderr, cpython_only from test import mod_generics_cache from test import _typed_dict_helper @@ -4615,6 +4615,7 @@ def blah(): blah() + @cpython_only # gh-98713 def test_overload_on_compiled_functions(self): with patch("typing._overload_registry", defaultdict(lambda: defaultdict(dict))): diff --git a/Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst b/Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst new file mode 100644 index 00000000000000..57e58943df4907 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst @@ -0,0 +1,3 @@ +Fix a bug in the :mod:`typing` tests where a test relying on CPython-specific +implementation details was not decorated with ``@cpython_only`` and was not +skipped on other implementations.