From 91d84d168095b0bb6744241749d4e8fbbe4cbcc1 Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Tue, 9 Mar 2021 11:40:07 +0100 Subject: [PATCH 1/2] bpo-43444: Move sqlite3 MODULE_NAME from setup.py to Modules/_sqlite/module.h --- Modules/_sqlite/cache.h | 3 +-- Modules/_sqlite/module.h | 1 + Modules/_sqlite/prepare_protocol.h | 3 +-- setup.py | 5 ----- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Modules/_sqlite/cache.h b/Modules/_sqlite/cache.h index 4a1977fcd2cd23..083356f93f9e4c 100644 --- a/Modules/_sqlite/cache.h +++ b/Modules/_sqlite/cache.h @@ -23,8 +23,7 @@ #ifndef PYSQLITE_CACHE_H #define PYSQLITE_CACHE_H -#define PY_SSIZE_T_CLEAN -#include "Python.h" +#include "module.h" /* The LRU cache is implemented as a combination of a doubly-linked with a * dictionary. The list items are of type 'Node' and the dictionary has the diff --git a/Modules/_sqlite/module.h b/Modules/_sqlite/module.h index 3185ec97888567..9aede92ea33c9e 100644 --- a/Modules/_sqlite/module.h +++ b/Modules/_sqlite/module.h @@ -27,6 +27,7 @@ #include "Python.h" #define PYSQLITE_VERSION "2.6.0" +#define MODULE_NAME "sqlite3" extern PyObject* pysqlite_Error; extern PyObject* pysqlite_Warning; diff --git a/Modules/_sqlite/prepare_protocol.h b/Modules/_sqlite/prepare_protocol.h index 42d07cbe9f16fe..593961331c90da 100644 --- a/Modules/_sqlite/prepare_protocol.h +++ b/Modules/_sqlite/prepare_protocol.h @@ -23,8 +23,7 @@ #ifndef PYSQLITE_PREPARE_PROTOCOL_H #define PYSQLITE_PREPARE_PROTOCOL_H -#define PY_SSIZE_T_CLEAN -#include "Python.h" +#include "module.h" typedef struct { diff --git a/setup.py b/setup.py index 554772217785db..3467f559e5808c 100644 --- a/setup.py +++ b/setup.py @@ -1571,12 +1571,7 @@ def detect_sqlite(self): '_sqlite/row.c', '_sqlite/statement.c', '_sqlite/util.c', ] - sqlite_defines = [] - if not MS_WINDOWS: - sqlite_defines.append(('MODULE_NAME', '"sqlite3"')) - else: - sqlite_defines.append(('MODULE_NAME', '\\"sqlite3\\"')) # Enable support for loadable extensions in the sqlite3 module # if --enable-loadable-sqlite-extensions configure option is used. From 07927e393a49031d7cb80d35058d25532e7e2e29 Mon Sep 17 00:00:00 2001 From: "Erlend E. Aasland" Date: Tue, 9 Mar 2021 15:12:54 +0100 Subject: [PATCH 2/2] Also remove MODULE_NAME from PCbuild --- PCbuild/_sqlite3.vcxproj | 1 - 1 file changed, 1 deletion(-) diff --git a/PCbuild/_sqlite3.vcxproj b/PCbuild/_sqlite3.vcxproj index 7e0062692b8f83..5eb8559d2925ec 100644 --- a/PCbuild/_sqlite3.vcxproj +++ b/PCbuild/_sqlite3.vcxproj @@ -94,7 +94,6 @@ $(sqlite3Dir);%(AdditionalIncludeDirectories) - MODULE_NAME="sqlite3";%(PreprocessorDefinitions)