Use monotonic time for sched, trace and subprocess modules

[vstinner]

BPO	14690
Nosy	@rhettinger, @abalkin, @vstinner, @giampaolo
Files	use_monotonic.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-05-30.11:31:52.054>
created_at = <Date 2012-04-29.01:18:53.448>
labels = []
title = 'Use monotonic time for sched, trace and subprocess modules'
updated_at = <Date 2012-05-30.11:31:52.052>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2012-05-30.11:31:52.052>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2012-05-30.11:31:52.054>
closer = 'python-dev'
components = []
creation = <Date 2012-04-29.01:18:53.448>
creator = 'vstinner'
dependencies = []
files = ['25400']
hgrepos = []
issue_num = 14690
keywords = ['patch']
message_count = 3.0
messages = ['159559', '159592', '161945']
nosy_count = 6.0
nosy_names = ['rhettinger', 'belopolsky', 'vstinner', 'giampaolo.rodola', 'neologix', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue14690'
versions = []

[vstinner]

The PEP-418 added a new time.monotonic() function. The sched, trace and subprocess modules should use it, if available, to avoid issues when the system time is changed.

Attached patch uses the time.monotonic() function when available.

See also the issue bpo-14222 (same issue for queue and threading) and the PEP-418.

--

socket and ssl modules should also use a monotonic clock if available, but these modules are implemented in C. The C implementation of time.monotonic() requires the librt library and is written in the timemodule.c. It requires more work to reuse it in the socket and ssl modules.

[neologix]

LGTM.
Juste one nitpick: why do you sometimes import the clock source as get_time() and others _time()? _time() looks fine to me.

[python-dev]

New changeset 1345cf58738d by Victor Stinner in branch 'default':
Close bpo-14690: Use monotonic clock instead of system clock in the sched,
http://hg.python.org/cpython/rev/1345cf58738d

[serhiy-storchaka]

It was a broken change for the sched module, because the enterabs() method takes an absolute time.

[vstinner]

@serhiy-storchaka

It was a broken change for the sched module, because the enterabs() method takes an absolute time.

Oh! You commented the change 12 years later. Does your comment mean that something should be changed? That the documentation is incomplete?

[serhiy-storchaka]

The documentation definitely should be changed.

[vstinner]

The documentation definitely should be changed.

Please open a new issue, or reopen this issue.

[serhiy-storchaka]

See #103417.