Skip to content

Commit f3bf304

Browse files
authored
gh-131357: Add a set of asserts to test.test_capi.test_bytearray (#131554)
add a set of asserts to test.test_capi.test_bytearray 1. Assert empty bytearray object for PyByteArray_Check. 2. Assert empty bytearray object for PyByteArray_CheckExact. 3. Assert 0-size bytearray object for PyByteArray_Size. 4. Assert empty bytearray object for PyByteArray_AsString. 5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat.
1 parent bc26f95 commit f3bf304

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

Lib/test/test_capi/test_bytearray.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class CAPITest(unittest.TestCase):
2020
def test_check(self):
2121
# Test PyByteArray_Check()
2222
check = _testlimitedcapi.bytearray_check
23+
self.assertTrue(check(bytearray(b'')))
2324
self.assertTrue(check(bytearray(b'abc')))
2425
self.assertFalse(check(b'abc'))
2526
self.assertTrue(check(ByteArraySubclass(b'abc')))
@@ -33,6 +34,7 @@ def test_check(self):
3334
def test_checkexact(self):
3435
# Test PyByteArray_CheckExact()
3536
check = _testlimitedcapi.bytearray_checkexact
37+
self.assertTrue(check(bytearray(b'')))
3638
self.assertTrue(check(bytearray(b'abc')))
3739
self.assertFalse(check(b'abc'))
3840
self.assertFalse(check(ByteArraySubclass(b'abc')))
@@ -78,7 +80,7 @@ def test_fromobject(self):
7880
def test_size(self):
7981
# Test PyByteArray_Size()
8082
size = _testlimitedcapi.bytearray_size
81-
83+
self.assertEqual(size(bytearray(b'')), 0)
8284
self.assertEqual(size(bytearray(b'abc')), 3)
8385
self.assertEqual(size(ByteArraySubclass(b'abc')), 3)
8486

@@ -89,7 +91,7 @@ def test_size(self):
8991
def test_asstring(self):
9092
"""Test PyByteArray_AsString()"""
9193
asstring = _testlimitedcapi.bytearray_asstring
92-
94+
self.assertEqual(asstring(bytearray(b''), 1), b'\0')
9395
self.assertEqual(asstring(bytearray(b'abc'), 4), b'abc\0')
9496
self.assertEqual(asstring(ByteArraySubclass(b'abc'), 4), b'abc\0')
9597
self.assertEqual(asstring(bytearray(b'abc\0def'), 8), b'abc\0def\0')
@@ -105,6 +107,7 @@ def test_concat(self):
105107
ba = bytearray(b'abc')
106108
self.assertEqual(concat(ba, b'def'), bytearray(b'abcdef'))
107109
self.assertEqual(ba, b'abc')
110+
self.assertEqual(concat(ba, ba), bytearray(b'abcabc'))
108111

109112
self.assertEqual(concat(b'abc', b'def'), bytearray(b'abcdef'))
110113
self.assertEqual(concat(b'a\0b', b'c\0d'), bytearray(b'a\0bc\0d'))

0 commit comments

Comments
 (0)