Skip to content

Commit 6b826d3

Browse files
authored
Remove the backport PR number, retain the original PR number (GH-56)
Closes python/miss-islington#53
1 parent bc512e3 commit 6b826d3

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

backport/status_change.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ async def merge_pr(gh, pr_number, sha):
8080
if commit["sha"] == sha:
8181
pr_commit_msg = commit["commit"]["message"].split("\n")
8282

83-
cleaned_up_title = f"{pr_commit_msg[0]} (GH-{pr_number})"
83+
cleaned_up_title = f"{pr_commit_msg[0]}"
8484
await gh.put(f"/repos/python/cpython/pulls/{pr_number}/merge",
8585
data={"commit_title": cleaned_up_title,
8686
"commit_message": "\n".join(pr_commit_msg[1:]),

tests/test_status_change.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ async def test_ci_passed_with_one_core_dev_review_pr_is_merged():
113113
assert len(gh.post_data["body"]) is not None # leaves a comment
114114
assert gh.put_data["sha"] == sha # is merged
115115
assert gh.put_data["merge_method"] == "squash"
116+
assert gh.put_data["commit_title"] == "bpo-32720: Fixed the replacement field grammar documentation. (GH-5544)"
116117

117118

118119
async def test_ci_passed_with_no_core_dev_review_pr_is_not_merged():
@@ -318,6 +319,7 @@ async def test_pr_reviewed_webhook_ci_passed_pr_is_merged():
318319
assert not hasattr(gh, 'post_data') # does not leave a comment
319320
assert gh.put_data["sha"] == sha # is merged
320321
assert gh.put_data["merge_method"] == "squash"
322+
assert gh.put_data["commit_title"] == "bpo-32720: Fixed the replacement field grammar documentation. (GH-5544)"
321323

322324

323325
async def test_pr_reviewed_webhook_ci_failure_pr_is_not_merged():

0 commit comments

Comments
 (0)