Skip to content

Commit 6a789ac

Browse files
author
Erlend E. Aasland
committed
Clean up tests
1 parent 217da20 commit 6a789ac

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

Lib/test/test_sqlite3/test_userfunctions.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -512,12 +512,12 @@ def setUp(self):
512512
("d", 12),
513513
("e", 9),
514514
]
515-
self.query = ("""
515+
self.query = """
516516
select x, %s(y) over (
517517
order by x rows between 1 preceding and 1 following
518518
) as sum_y
519519
from test order by x
520-
""")
520+
"""
521521
self.con.create_window_function("sumint", 1, WindowSumInt)
522522

523523
def test_win_sum_int(self):
@@ -531,7 +531,7 @@ def test_win_error_on_create(self):
531531

532532
@with_tracebacks(BadWindow)
533533
def test_win_exception_in_method(self):
534-
for meth in ["__init__", "step", "value", "inverse"]:
534+
for meth in "__init__", "step", "value", "inverse":
535535
with self.subTest(meth=meth):
536536
with patch.object(WindowSumInt, meth, side_effect=BadWindow):
537537
name = f"exc_{meth}"
@@ -578,7 +578,6 @@ def finalize(self): return 42
578578
with self.subTest(meth=meth, cls=cls):
579579
name = f"exc_{meth}"
580580
self.con.create_window_function(name, 1, cls)
581-
self.addCleanup(self.con.create_window_function, name, 1, None)
582581
with self.assertRaisesRegex(sqlite.OperationalError,
583582
f"'{meth}' method not defined"):
584583
self.cur.execute(self.query % name)
@@ -596,7 +595,6 @@ def inverse(self, x): pass
596595

597596
name = "missing_finalize"
598597
self.con.create_window_function(name, 1, MissingFinalize)
599-
self.addCleanup(self.con.create_window_function, name, 1, None)
600598
self.cur.execute(self.query % name)
601599
self.cur.fetchall()
602600

@@ -617,6 +615,7 @@ class ErrorValueReturn:
617615
def __init__(self): pass
618616
def step(self, x): pass
619617
def value(self): return 1 << 65
618+
620619
self.con.create_window_function("err_val_ret", 1, ErrorValueReturn)
621620
self.assertRaisesRegex(sqlite.DataError, "string or blob too big",
622621
self.cur.execute, self.query % "err_val_ret")

0 commit comments

Comments
 (0)