[3.12] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) (#120986)

miss-islington · allsey87 · web-flow · commit 433a5f89c911 · 2024-06-25T08:11:22.000Z
gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) Add missing space in AS_VAR_APPEND() on CFLAGS. (cherry picked from commit 2106c9b) Co-authored-by: Michael Allwright <allsey87@gmail.com>
diff --git a/Misc/NEWS.d/next/Build/2024-06-21-09-24-03.gh-issue-120671.Z8sBQB.rst b/Misc/NEWS.d/next/Build/2024-06-21-09-24-03.gh-issue-120671.Z8sBQB.rst
@@ -0,0 +1 @@
+Fix failing configure tests due to a missing space when appending to CFLAGS.
diff --git a/configure b/configure
diff --git a/configure.ac b/configure.ac
@@ -2371,7 +2371,7 @@ AC_DEFUN([PY_CHECK_CC_WARNING], [
   AS_VAR_PUSHDEF([py_var], [ac_cv_$1_]m4_normalize($2)[_warning])
   AC_CACHE_CHECK([m4_ifblank([$3], [if we can $1 $CC $2 warning], [$3])], [py_var], [
     AS_VAR_COPY([py_cflags], [CFLAGS])
-    AS_VAR_APPEND([CFLAGS], ["-W$2 -Werror"])
+    AS_VAR_APPEND([CFLAGS], [" -W$2 -Werror"])
     AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
                       [AS_VAR_SET([py_var], [yes])],
                       [AS_VAR_SET([py_var], [no])])

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix failing configure tests due to a missing space when appending to CFLAGS.`