Skip to content

Add --no-push option to cherry_picker.py #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mariatta opened this issue May 3, 2017 · 3 comments
Closed

Add --no-push option to cherry_picker.py #78

Mariatta opened this issue May 3, 2017 · 3 comments
Assignees

Comments

@Mariatta
Copy link
Member

Mariatta commented May 3, 2017

I've been thinking of adding --no-push option.
It will fetch from upstream, checkout the cherry-pick branch, and do git cherry-pick.
This will allow us to test the change locally before pushing the changes.
Once we're satisfied with it, we can use --continue (implemented in #68) that will do the rest (git push, open web browser, and delete the branch).

What does everyone think about this?

@louisom
Copy link
Contributor

louisom commented May 3, 2017

This sounds great, instead only impl --continue, maybe add --abort (delete local branch, recover..etc) like git rebase?

@Mariatta
Copy link
Member Author

Mariatta commented May 3, 2017

--abort has also been implemented in #68 (deletes the backport branch and checkout master) so yes, people have both options :)

@louisom
Copy link
Contributor

louisom commented May 3, 2017

@Mariatta ah, that's cool. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants