Skip to content

Teach cherry_picker to forwardport to master #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andresdelfino opened this issue Jun 24, 2018 · 2 comments
Closed

Teach cherry_picker to forwardport to master #270

andresdelfino opened this issue Jun 24, 2018 · 2 comments

Comments

@andresdelfino
Copy link
Contributor

andresdelfino commented Jun 24, 2018

In #7765 , I opened a PR for 3.6 that was intended for master. After it was committed, I had to forwardport it to master.

When trying to do that, cherry_picker throw an error because it doesn't expect branch names without the X.Y format.

I ended up editing the script for this particular PR.

I know this isn't usual, but if deemed useful, I can take the task and make a PR.

@andresdelfino
Copy link
Contributor Author

python/cpython#7765

@Mariatta
Copy link
Member

Thanks, but I'm -1 on this idea. It is not an official CPython's workflow.

cherry_picker is convenience tool, and I don't think we should make forward porting too convenient.
(core devs going to need to be more careful next time 🙂).

I think we will focus on preventative measures, as discussed in #211 and python/bedevere#111.

It could also be ported manually the old fashioned way, using git cherry-pick

git fetch upstream
git checkout -b port-pr-x-to-master upstream/x.y
git cherry-pick -x commithash
git push origin port-pr-x-to-master
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants