Skip to content

OAS validation with JSONSchema #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2019
Merged

OAS validation with JSONSchema #157

merged 4 commits into from
Sep 13, 2019

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Sep 4, 2019

New OAS validation will fix many issues with schema validation in openapi core.

Fixes #155 #147 #129 #127 #122 #115 #103 #77

Partially fixes #139 #100 (see https://github.com/p1c2u/openapi-core/pull/157/files#diff-c509eb72d0b1058bf79f8f2ac563b7afR231).

@p1c2u p1c2u force-pushed the feature/validation-refactor branch 2 times, most recently from cba3da6 to 6c73af4 Compare September 4, 2019 21:27
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #157 into master will decrease coverage by 0.68%.
The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   96.38%   95.69%   -0.69%     
==========================================
  Files          58       62       +4     
  Lines        1661     1697      +36     
==========================================
+ Hits         1601     1624      +23     
- Misses         60       73      +13
Impacted Files Coverage Δ
openapi_core/schema/schemas/unmarshallers.py 100% <ø> (ø) ⬆️
openapi_core/schema/schemas/exceptions.py 83.67% <ø> (+0.62%) ⬆️
openapi_core/schema/media_types/models.py 94.59% <100%> (+9.3%) ⬆️
openapi_core/schema/schemas/types.py 100% <100%> (ø)
openapi_core/schema/specs/models.py 95.55% <100%> (+0.1%) ⬆️
openapi_core/schema/schemas/_types.py 100% <100%> (ø)
openapi_core/schema/parameters/models.py 97.26% <100%> (+2.97%) ⬆️
openapi_core/shortcuts.py 100% <100%> (ø) ⬆️
openapi_core/validation/response/validators.py 100% <100%> (ø) ⬆️
openapi_core/schema/specs/factories.py 100% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f414b18...fc60083. Read the comment docs.

@p1c2u p1c2u force-pushed the feature/validation-refactor branch 3 times, most recently from 6396c8b to 53c9090 Compare September 12, 2019 22:00
@p1c2u p1c2u force-pushed the feature/validation-refactor branch from 53c9090 to fc60083 Compare September 13, 2019 00:55
@p1c2u p1c2u merged commit 4690f77 into master Sep 13, 2019
@p1c2u p1c2u deleted the feature/validation-refactor branch September 13, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating nested items in array elements types Poor error reporting when using oneOf
1 participant