Skip to content

Documentation does not reflect proper usage of Falcon request and response factories #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stojan-jovic opened this issue Apr 13, 2020 · 2 comments

Comments

@stojan-jovic
Copy link

In current documentation we have something like this:

from openapi_core.contrib.falcon import FalconOpenAPIRequest
from openapi_core.contrib.falcon import FalconOpenAPIResponse

But that will not work with current openapi-core version (i.e. 0.13.3).

Solution is probably to add in openapi_core.contrib.falcon something like:

# backward compatibility
FalconOpenAPIRequest = FalconOpenAPIRequestFactory.create
FalconOpenAPIResponse = FalconOpenAPIResponseFactory.create

(so, similar to Flask's factories)

Or simply fix documentation.

@dlarrick
Copy link
Contributor

#233 fixes the documentation, FYI

@stojan-jovic
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants