Skip to content

Any plans on validating security data in request? #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
playpauseandstop opened this issue Jan 29, 2020 · 2 comments · Fixed by #195
Closed

Any plans on validating security data in request? #187

playpauseandstop opened this issue Jan 29, 2020 · 2 comments · Fixed by #195
Labels
area/validation/request Indicates an issue on request validation area. kind/missing-implementation

Comments

@playpauseandstop
Copy link

Hi,

First of all, thanks a lot for openapi-core library. It (as well as pyramid_openapi3) helps me a lot for bringing OpenAPI 3 support for aiohttp.web applications (see https://github.com/playpauseandstop/rororo, if you're interested).

However, I'd like to know whether you have any plans in providing security data validation within openapi-core?

As you might now OpenAPI 3 allows user to secure operation with one or several security schemes, such as,

  • Basic HTTP
  • JWT Token
  • API Key
  • OpenID Connect
  • OAuth2

But latest openapi-core release: 0.12.0 doesn't allow developer to check whether request contains requested security data or not.

In my library, rororo, I managed to check security data for simpler cases in Basic HTTP, JWT Token & API Key and wonder whether you plan to add this security check to openapi-core?

If you're interested, I'm willing to help with given feature.

Thanks

@p1c2u
Copy link
Collaborator

p1c2u commented Feb 3, 2020

@playpauseandstop

That's not something in high priorities. You code is very useful and can be considered as good starting point. I will try to prepare PoC shortly. Thanks.

@p1c2u p1c2u added kind/missing-implementation area/validation/request Indicates an issue on request validation area. labels Feb 3, 2020
@p1c2u p1c2u closed this as completed in #195 Feb 4, 2020
@p1c2u
Copy link
Collaborator

p1c2u commented Feb 4, 2020

Prepare basic security process. Feel free to extend it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/validation/request Indicates an issue on request validation area. kind/missing-implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants