Skip to content

Vendored importlib_resources uses obsolete typing.io import #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srittau opened this issue May 18, 2022 · 1 comment · Fixed by #5150
Closed

Vendored importlib_resources uses obsolete typing.io import #5106

srittau opened this issue May 18, 2022 · 1 comment · Fixed by #5150
Assignees
@matteius
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.

Comments

@srittau
Copy link

srittau commented May 18, 2022

Issue description

The vendored version of importlib_resources uses the typing.io namespace, which is deprecated since Python 3.8 and will be removed in Python 3.12 (cf. python/cpython#92871). This was seemingly fixed in importlib_resources v5.2.1 (according to the changelog).
@srittau srittau mentioned this issue May 18, 2022
Merged
@matteius matteius self-assigned this May 26, 2022
@matteius matteius added the Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. label May 26, 2022
@oz123
Copy link
Contributor

oz123 commented Jun 26, 2022

I think we can completely drop this vendored library. I don't see it used any where.

@oz123 oz123 mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matteius matteius

Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove importlib_metadata and importlib_resources pypa/pipenv
3 participants
@srittau @matteius @oz123