Skip to content

Do we need pickler from pytensor? #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferrine opened this issue Dec 14, 2022 · 3 comments
Open

Do we need pickler from pytensor? #132

ferrine opened this issue Dec 14, 2022 · 3 comments

Comments

@ferrine
Copy link
Member

ferrine commented Dec 14, 2022

Description

I discovered this file but literally do not know we had to deal with it for all the 5 years of my involvement in pymc
https://github.com/pymc-devs/pytensor/blob/5affc30827add3ebe3495d150edf62b782def1db/pytensor/misc/pkl_utils.py

I found it is used in

import pytensor.misc.pkl_utils

Can we just implement a proper __getstate__?

@ferrine ferrine changed the title Did we ever used pickler from pytensor? Did we ever use pickler from pytensor? Dec 14, 2022
@ferrine ferrine mentioned this issue Dec 14, 2022
6 tasks
@ferrine ferrine changed the title Did we ever use pickler from pytensor? Do we need pickler from pytensor? Dec 14, 2022
@michaelosthege
Copy link
Member

In PyMC we use cloudpickle and that works just fine.

The test_pkl_utils.py is suspiciously short, and pkl_utils wasn't changed much in the past two years.
The ZIP file approach sounds very hackish too..

Maybe remove it?

@ricardoV94
Copy link
Member

@ferrine was this removed in #111?

@michaelosthege
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants