Skip to content

Remove deprecated pytensor.tensor.nnet,signal #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferrine opened this issue Dec 13, 2022 · 1 comment · Fixed by #111
Closed

Remove deprecated pytensor.tensor.nnet,signal #124

ferrine opened this issue Dec 13, 2022 · 1 comment · Fixed by #111

Comments

@ferrine
Copy link
Member

ferrine commented Dec 13, 2022

Description

python setup.py version
running version
keywords are unexpanded, not using
got version from VCS {'version': '2.8.10+90.g10610f5bb', 'full-revisionid': '10610f5bbe8396cf51791f9c1c46884c75d1df57', 'dirty': False, 'error': None, 'date': '2022-12-13T23:53:11+0300'}
Version: 2.8.10+90.g10610f5bb
 full-revisionid: 10610f5bbe8396cf51791f9c1c46884c75d1df57
 dirty: False
 date: 2022-12-13T23:53:11+0300

I guess we consider to bump version very soon. This module was marked for removal in the nest release.

warnings.warn(
"The module `pytensor.tensor.nnet` is deprecated and will "
"be removed from PyTensor in version 2.9.0",
DeprecationWarning,
stacklevel=2,
)

warnings.warn(
"The module `pytensor.tensor.signal` is deprecated and will "
"be removed from PyTensor in version 2.9.0.",
DeprecationWarning,
stacklevel=2,
)

warnings.warn(
"The module `pytensor.tensor.signal` is deprecated and will "
"be removed from PyTensor in version 2.8.5.",
DeprecationWarning,
stacklevel=2,
)

@ferrine ferrine changed the title Remove deprecatet Remove deprecated pytensor/tensor/nnet Dec 13, 2022
@ferrine ferrine changed the title Remove deprecated pytensor/tensor/nnet Remove deprecated pytensor.tensor.nnet Dec 13, 2022
@ferrine ferrine mentioned this issue Dec 13, 2022
6 tasks
@ricardoV94
Copy link
Member

ricardoV94 commented Dec 14, 2022

We want to keep the conv2D around. We can drop the rest. We can move it to tensor/extra_ops if that still exists

@ferrine ferrine changed the title Remove deprecated pytensor.tensor.nnet Remove deprecated pytensor.tensor.nnet,signal Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants