Remove include/pybind11/smart_holder.h

rwgk · rwgk · commit 4d8973ec9120 · 2025-02-22T13:28:13.000-08:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -164,7 +164,6 @@ set(PYBIND11_HEADERS
     include/pybind11/operators.h
     include/pybind11/pybind11.h
     include/pybind11/pytypes.h
-    include/pybind11/smart_holder.h
     include/pybind11/stl.h
     include/pybind11/stl_bind.h
     include/pybind11/stl/filesystem.h
diff --git a/include/pybind11/smart_holder.h b/include/pybind11/smart_holder.h
diff --git a/tests/extra_python_package/test_files.py b/tests/extra_python_package/test_files.py
@@ -43,7 +43,6 @@
     "include/pybind11/options.h",
     "include/pybind11/pybind11.h",
     "include/pybind11/pytypes.h",
-    "include/pybind11/smart_holder.h",
     "include/pybind11/stl.h",
     "include/pybind11/stl_bind.h",
     "include/pybind11/trampoline_self_life_support.h",
diff --git a/tests/test_class_sh_basic.cpp b/tests/test_class_sh_basic.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_disowning.cpp b/tests/test_class_sh_disowning.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_disowning_mi.cpp b/tests/test_class_sh_disowning_mi.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_factory_constructors.cpp b/tests/test_class_sh_factory_constructors.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_inheritance.cpp b/tests/test_class_sh_inheritance.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_mi_thunks.cpp b/tests/test_class_sh_mi_thunks.cpp
@@ -1,6 +1,3 @@
-#include <pybind11/pybind11.h>
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <cstddef>
diff --git a/tests/test_class_sh_property.cpp b/tests/test_class_sh_property.cpp
@@ -3,7 +3,6 @@
 // valu(e), ref(erence), ptr or p (pointer), r = rvalue, m = mutable, c = const,
 // sh = shared_ptr, uq = unique_ptr.
 
-#include "pybind11/smart_holder.h"
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_property_non_owning.cpp b/tests/test_class_sh_property_non_owning.cpp
@@ -1,4 +1,3 @@
-#include "pybind11/smart_holder.h"
 #include "pybind11_tests.h"
 
 #include <cstddef>
diff --git a/tests/test_class_sh_shared_ptr_copy_move.cpp b/tests/test_class_sh_shared_ptr_copy_move.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_trampoline_basic.cpp b/tests/test_class_sh_trampoline_basic.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_trampoline_self_life_support.cpp b/tests/test_class_sh_trampoline_self_life_support.cpp
@@ -2,7 +2,6 @@
 // All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-#include "pybind11/smart_holder.h"
 #include "pybind11/trampoline_self_life_support.h"
 #include "pybind11_tests.h"
 
diff --git a/tests/test_class_sh_trampoline_shared_from_this.cpp b/tests/test_class_sh_trampoline_shared_from_this.cpp
@@ -2,7 +2,6 @@
 // All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-#include "pybind11/smart_holder.h"
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_trampoline_shared_ptr_cpp_arg.cpp b/tests/test_class_sh_trampoline_shared_ptr_cpp_arg.cpp
@@ -2,7 +2,6 @@
 // All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-#include "pybind11/smart_holder.h"
 #include "pybind11_tests.h"
 
 #include <utility>
diff --git a/tests/test_class_sh_trampoline_unique_ptr.cpp b/tests/test_class_sh_trampoline_unique_ptr.cpp
@@ -2,7 +2,6 @@
 // All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-#include "pybind11/smart_holder.h"
 #include "pybind11/trampoline_self_life_support.h"
 #include "pybind11_tests.h"
 
diff --git a/tests/test_class_sh_unique_ptr_custom_deleter.cpp b/tests/test_class_sh_unique_ptr_custom_deleter.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_unique_ptr_member.cpp b/tests/test_class_sh_unique_ptr_member.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>
diff --git a/tests/test_class_sh_virtual_py_cpp_mix.cpp b/tests/test_class_sh_virtual_py_cpp_mix.cpp
@@ -1,5 +1,3 @@
-#include <pybind11/smart_holder.h>
-
 #include "pybind11_tests.h"
 
 #include <memory>

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-#include <pybind11/smart_holder.h>`
`2`		`-`
`3`	`1`	`#include "pybind11_tests.h"`
`4`	`2`
`5`	`3`	`#include <memory>`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-#include "pybind11/smart_holder.h"`
`2`	`1`	`#include "pybind11_tests.h"`
`3`	`2`
`4`	`3`	`#include <cstddef>`