fix: glocal check stops at windows disk root (#1119)

Author: Jason Kuhrt

.github/workflows/pr.yml

@@ -18,12 +18,10 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - run: yarn --frozen-lockfile
       - run: yarn -s build
-      - run: yarn -s test runtime/app runtime/schema/settings lib/build runtime/schema/index lib/nexus-schema-backing-types lib/graphql-client runtime/server runtime/schema/settings-mapper lib/plugin lib/add-to-context-extractor
+      - run: yarn -s test runtime/app runtime/schema/settings lib/build runtime/schema/index lib/nexus-schema-backing-types lib/graphql-client runtime/server runtime/schema/settings-mapper lib/plugin lib/add-to-context-extractor lib/glocal
       # todo
       # lib/layout
-      # lib/glocal
       # lib/watcher
-
   unit-tests:
     runs-on: ubuntu-latest
     strategy:
@@ -38,7 +36,6 @@ jobs:
       - run: yarn --frozen-lockfile
       - run: yarn -s build
       - run: yarn -s test:unit
-
   system-tests:
     runs-on: ubuntu-latest
     strategy:
@@ -56,7 +53,7 @@ jobs:
       - run: yarn -s build
       - name: Setup global git user
         run: |
-          # For nexus create app flow which will make an init commit 
+          # For nexus create app flow which will make an init commit
           git config --global user.name prisma-labs
           git config --global user.email [email protected]
       - run: yarn -s test system/${{matrix.test-case}}

.github/workflows/trunk.yml

@@ -18,10 +18,9 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - run: yarn --frozen-lockfile
       - run: yarn -s build
-      - run: yarn -s test runtime/app runtime/schema/settings lib/build runtime/schema/index lib/nexus-schema-backing-types lib/graphql-client runtime/server runtime/schema/settings-mapper lib/plugin lib/add-to-context-extractor
+      - run: yarn -s test runtime/app runtime/schema/settings lib/build runtime/schema/index lib/nexus-schema-backing-types lib/graphql-client runtime/server runtime/schema/settings-mapper lib/plugin lib/add-to-context-extractor lib/glocal
       # todo
       # lib/layout
-      # lib/glocal
       # lib/watcher
 
   unit-tests:

src/lib/fs.ts

@@ -69,7 +69,7 @@ export function findFileRecurisvelyUpwardSync(
       break
     }
 
-    if (currentDir === '/') {
+    if (isRootPath(currentDir)) {
       break
     }
 
@@ -232,3 +232,23 @@ export async function isEmptyDir(dirPath: string): Promise<boolean> {
   const contents = await FS.listAsync(dirPath)
   return contents === undefined || contents.length === 0
 }
+
+// https://github.com/iojs/io.js/blob/5883a59b21a97e8b7339f435c977155a2c29ba8d/lib/path.js#L43
+const windowsPathRegex = /^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/]+[^\\/]+)?[\\/]$/
+
+/**
+ * Ask whether the given path is a root path or not.
+ *
+ * @remarks
+ *
+ * Take from https://github.com/sindresorhus/is-root-path/blob/master/index.js
+ */
+export function isRootPath(path: string) {
+  path = path.trim()
+
+  if (path === '') {
+    return false
+  }
+
+  return process.platform === 'win32' ? windowsPathRegex.test(path) : path === '/'
+}

src/lib/glocal/detect-exec-layout.spec.ts

@@ -1,20 +1,20 @@
 import * as path from 'path'
 import * as TestContext from '../test-context'
-import { Param1, repalceInObject } from '../utils'
+import { normalizePathsInData, Param1 } from '../utils'
 import { detectExecLayout } from './detect-exec-layout'
 
 const ctx = TestContext.compose(TestContext.tmpDir(), TestContext.fs(), (ctx) => {
   return {
     detectExecLayout: (input?: Partial<Param1<typeof detectExecLayout>>) => {
-      return repalceInObject(
-        ctx.tmpDir,
-        '/__dynamic__',
+      return normalizePathsInData(
         detectExecLayout({
           depName: 'a',
           cwd: ctx.tmpDir,
           scriptPath: ctx.fs.path('some/other/bin/a'),
           ...input,
-        })
+        }),
+        ctx.tmpDir,
+        '/__dynamic__'
       )
     },
   }
@@ -54,7 +54,6 @@ describe('node project detection', () => {
     })
   })
   it('if package.json not present then is not a node project', () => {
-    expect(ctx.detectExecLayout().nodeProject).toEqual(false)
     expect(ctx.detectExecLayout()).toMatchObject({
       nodeProject: false,
       toolProject: false,

src/lib/glocal/detect-exec-layout.ts

@@ -124,8 +124,9 @@ export function detectExecLayout(input: Input): ExecScenario {
 
   let isToolProject = null
   try {
+    // todo test that not using Path.posix will break on windows
     isToolProject =
-      typeof require(Path.join(projectDir, 'package.json'))?.dependencies?.[input.depName] === 'string'
+      typeof require(Path.posix.join(projectDir, 'package.json'))?.dependencies?.[input.depName] === 'string'
   } catch (e) {
     console.log(e)
   }