From 7405281cbb7126ba4321d7561106560d30a8c718 Mon Sep 17 00:00:00 2001 From: Antoine Roy-Gobeil Date: Tue, 13 Aug 2019 11:46:10 -0400 Subject: [PATCH 1/2] sankey: do not stash initial view for traces not visible --- src/traces/sankey/plot.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/traces/sankey/plot.js b/src/traces/sankey/plot.js index b7b953548f3..9b14ec6caac 100644 --- a/src/traces/sankey/plot.js +++ b/src/traces/sankey/plot.js @@ -129,6 +129,7 @@ module.exports = function plot(gd, calcData) { // stash initial view for(var i = 0; i < gd._fullData.length; i++) { + if(!gd._fullData[i].visible) continue; if(gd._fullData[i].type !== cn.sankey) continue; if(!gd._fullData[i]._viewInitial) { var node = gd._fullData[i].node; From 25c0f02d25355468785e386fdd12b462094363e9 Mon Sep 17 00:00:00 2001 From: Antoine Roy-Gobeil Date: Tue, 13 Aug 2019 11:50:17 -0400 Subject: [PATCH 2/2] sankey: add an invisible subplot to existing mock This is meant to :lock: down fix for issue #4119 --- test/image/mocks/sankey_subplots.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/image/mocks/sankey_subplots.json b/test/image/mocks/sankey_subplots.json index fe20a584f86..bbe066cf319 100644 --- a/test/image/mocks/sankey_subplots.json +++ b/test/image/mocks/sankey_subplots.json @@ -36,6 +36,10 @@ "value": [120, 50], "label": ["stram4", "stream5"] } + }, + { + "visible": false, + "type": "sankey" } ], "layout": {