espsoftwareserial 6.4.0 readBytes always returns -1

[dirkmueller]

with the change

0b9ac7c#diff-67183b415c133795f221633c3e752798L193-R196

The readBytes() method now always returns -1 in 9600-baud-8N1 serial mode, which breaks my application.

I suggest to do a change similar to this:

    if (m_parityBuffer && 0 != size) {
        uint32_t parityBits = size;
        while (m_parityOutPos >>= 1) ++parityBits;
        m_parityOutPos = (1 << (parityBits % 8));
        m_parityBuffer->pop_n(nullptr, parityBits / 8);
        return size;
    }
-   return -1;
+   return 0 != size ? size : -1;

alternatively returning size always might not be a bad situation either (would work for me), but it is a change in contract/behavior then.

[dok-net]

OMG - apparently a failure in my testing process. Fixing ASAP.

[dok-net]

@dirkmueller Please test for regressions and let me know. Thanks! Check the README for instructions on how to use non-release versions of EspSoftwareSerial with ESP8266.

[dirkmueller]

thanks for the quick turnaround. Changes look good to me. I'll do a closer retesting later tonight.

[dirkmueller]

current master seems to work all fine. please release!