-
-
Notifications
You must be signed in to change notification settings - Fork 421
Strict should not allow a trailing slash #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi everyone! I currently have this issue : vuejs/vue-router#1443 when I use A solution is to simply set On my server, I set:
This is my initial cases:
So I decide to use BUT I have two issues now !
What I expected:
|
I don't follow this issue or understand the next comment, sorry. This is already how it works. See the test case: Lines 116 to 132 in e97122d
|
oh, what the hell 😆 |
Hello,
First, thanks a lot for creating
path-to-repexp
, we use it to handle paths in vue-router and it makes things pretty easy 🙂When using
strict: true
, a path will only match with a trailing slash:/foo
->/foo/
but no/foo
but this looks strange because I see no way to force a path not to have a trailing slash
? ->
/foo
but not/foo/
IMO, it would make more sense to allow the user to force the slash by simply appending it to the route:
/foo/
->/foo/
but not/foo
Now, I know this is a breaking channge but still wanted to know your thoughts about this because I couldn't find any previous issue about the topic
The text was updated successfully, but these errors were encountered: