Skip to content

master fails to compile with icu 63 #18860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SjonHortensius opened this issue Jun 16, 2025 · 3 comments · May be fixed by #18868
Open

master fails to compile with icu 63 #18860

SjonHortensius opened this issue Jun 16, 2025 · 3 comments · May be fixed by #18868

Comments

@SjonHortensius
Copy link
Contributor

Description

I'm looking at SjonHortensius/3v4l_org#41 which fails, probably caused by #18519

The referenced issue did not intend to bump the minimum version of icu:

... On older versions of ICU, we only allow TYPE_AND and WIDTH_WIDE - we need this because (...) the minimum version ICU supported is 57, which was bumped from 50 last year.

However, with icu 63 it no longer compiles saying: ext/intl/listformatter/listformatter_arginfo.h:41:35: error: ‘ULISTFMT_TYPE_AND’ undeclared (first use in this function); did you mean ‘ULISTFMT_ELEMENT_FIELD’?

@BogdanUngureanu

PHP Version

master

Operating System

No response

@BogdanUngureanu
Copy link
Contributor

Hi Sjon, I'll look into it tonight. :)

@Ayesh
Copy link
Member

Ayesh commented Jun 16, 2025

icu::ListFormatter is from ICU 50, but the ULISTFMT_TYPE_AND const is indeed from ICU 67 while the intl extension only requires ICU 57.1.

I suppose we can wrap the new class with #if U_ICU_VERSION_MAJOR_NUM >= 67. @BogdanUngureanu feel free to work on it please, otherwise I can pick up later this week too.

@BogdanUngureanu
Copy link
Contributor

@Ayesh I don't think that's necessary; we just need to not use those constants for that ICU target. I'll open a PR ASAP for it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants