Skip to content

Detect trailing spaces in *.robot files #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Jul 27, 2019 · 6 comments
Closed

Detect trailing spaces in *.robot files #1104

php-coder opened this issue Jul 27, 2019 · 6 comments
Assignees
Labels
ADR/needed A decision has been made and it needs to be documented area/ci resolution/gone Non-reproducible, obsolete, outdated issues
Milestone

Comments

@php-coder
Copy link
Owner

A couple of times I've merged PRs and I've noticed trailing spaces in the *.robot files too late. We need to detect such violations and fail earlier.

rflint should support it, but it doesn't: boakley/robotframework-lint#37

So, here what we can do:

  • contribute such a support to rflint
  • write a custom rule for rflint
  • add a simple check to Danger (it could be just a single grep invocation)
@php-coder php-coder changed the title Detect trailing spaced in *.robot files Detect trailing spaces in *.robot files Jul 27, 2019
@php-coder
Copy link
Owner Author

A couple of times I've merged PRs

Here is the commits where I had to fix trailing spaces:

As I see, we need to detect this not only for *.robot files but also for HTML content.

@php-coder
Copy link
Owner Author

One more: faf5474

@php-coder php-coder added this to the 0.4.1 milestone Aug 25, 2019
@php-coder
Copy link
Owner Author

Yet another one: 5d78e2b

@mukeshk
Copy link
Contributor

mukeshk commented Aug 26, 2019 via email

@php-coder
Copy link
Owner Author

@mukeshk I don't blame you as it should be spotted by our scripts. I also haven't noticed it during review so this is something that just should be automated.

@php-coder
Copy link
Owner Author

One more: f62ebd2

@php-coder php-coder modified the milestones: 0.4.1, 0.4.2 Sep 8, 2019
@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Feb 9, 2024
@php-coder php-coder self-assigned this Feb 9, 2024
@php-coder php-coder modified the milestones: next, 0.4.8 Feb 9, 2024
@php-coder php-coder added the resolution/gone Non-reproducible, obsolete, outdated issues label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR/needed A decision has been made and it needs to be documented area/ci resolution/gone Non-reproducible, obsolete, outdated issues
Projects
None yet
Development

No branches or pull requests

2 participants