Skip to content

Ensure that commits messages conform the convention #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
php-coder opened this issue Jun 28, 2019 · 8 comments
Open

Ensure that commits messages conform the convention #1062

php-coder opened this issue Jun 28, 2019 · 8 comments
Assignees
Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts
Milestone

Comments

@php-coder
Copy link
Owner

We use https://www.conventionalcommits.org in this repo and need to ensure that the messages in PRs are also conform to this convention.

@php-coder php-coder added this to the 0.4.1 milestone Jun 28, 2019
@php-coder php-coder self-assigned this Jun 28, 2019
@php-coder php-coder modified the milestones: 0.4.1, 0.4.2 Sep 8, 2019
@php-coder
Copy link
Owner Author

I've enabled Semantic Pull Requests Bot for this repo:

Let's give it a try because I wasn't able to implement this check as I planned (choose some tool, run on Travis, analyze with Danger) in a short period of time. This bots works only with pull requests, so direct commits aren't validated. But it's better to have something than nothing at all.

Perhaps, we need to add .github/semantic.yml with commitsOnly: true configuration and customized types (for example, we have task).

@php-coder
Copy link
Owner Author

Another bot to consider: https://github.com/z0al/commitlint-bot

@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder
Copy link
Owner Author

php-coder commented Nov 9, 2019

BTW we can also add a badge for that, like this one: https://github.com/ridedott/dependabot-auto-merge-action

@php-coder
Copy link
Owner Author

Could be related if we'll use GitHub Actions: https://github.com/marketplace/actions/commit-linter

@php-coder
Copy link
Owner Author

Another bot: https://gitcop.com

@php-coder
Copy link
Owner Author

@php-coder
Copy link
Owner Author

I've enabled Semantic Pull Requests Bot for this repo:

I have 9 commits and one of them isn't semantic (starts with "[DO NOT MERGE]") and this bot seems doesn't detect that (its status is ready to be merged or rebased)

@php-coder
Copy link
Owner Author

Semantic Pull Requests Bot has been decommissioned. I'm trying to understand why I don't see TravisCI checks in pull requests and I have a theory that semantic bot is shadowing Travis status.

@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts
Projects
None yet
Development

No branches or pull requests

1 participant