ci: decomission of shellcheck

The following issue won't be fixed:
Closes #710
Closes #1615

Part of #1669

Author: php-coder

.github/workflows/static-analysis.yml

@@ -90,21 +90,6 @@ jobs:
       - name: Check license header
         run: ./src/main/scripts/execute-command.sh check-license
 
-  run-shellcheck:
-    name: Run ShellCheck
-    # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Clone source code
-        uses: actions/[email protected] # https://github.com/actions/checkout
-        with:
-          # Whether to configure the token or SSH key with the local git config. Default: true
-          persist-credentials: false
-      - name: Show shellcheck version
-        run: shellcheck --version
-      - name: Run shellcheck
-        run: ./src/main/scripts/execute-command.sh shellcheck
-
   run-enforcer:
     name: Run maven-enforcer-plugin
     # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on

src/main/scripts/ci/connect-todos-to-issues.sh

@@ -59,7 +59,6 @@ ENABLE_DEBUG=
 ISSUE_LABEL=techdebt
 
 # We intentionally use single quotes as the real values will be substituted during `eval` call later
-# shellcheck disable=SC2016
 ISSUE_BODY_TEMPLATE='echo "The puzzle \`${PUZZLE_ID}\` from #$ORIG_ISSUE has to be resolved:
 
 https://github.com/${GITHUB_REPOSITORY}/blob/${GITHUB_SHA}/${PUZZLE_FILE}#L${PUZZLE_LINE_START}-L${PUZZLE_LINE_END}
@@ -86,7 +85,6 @@ PUZZLES_COUNT=0
 NEW_ISSUES_COUNT=0
 
 # UNUSED_REST is really unused but without it, read appends the rest of a line to the last variable
-# shellcheck disable=SC2034
 while IFS=$'\t' read -r PUZZLE_ID UNUSED_TICKET TITLE UNUSED_REST; do
     PUZZLES_COUNT=$((PUZZLES_COUNT + 1))
 
@@ -151,7 +149,6 @@ while IFS=$'\t' read -r PUZZLE_ID UNUSED_TICKET TITLE UNUSED_REST; do
         error "    1) modify a body of one of the tickets to not contain puzzle id (or to have a different title)"
         error "    2) manually create a mapping between this puzzle and one of the issues:"
         # UNUSED_REST is really unused but without it, read appends the rest of a line to the last variable
-        # shellcheck disable=SC2034
         echo "$CANDIDATES" | while read -r ISSUE_ID ISSUE_STATE UNUSED_REST; do
             error "       echo '$PUZZLE_ID\t$ISSUE_ID\t$ISSUE_STATE\tmanually' >>$ISSUES_MAPPING_FILE"
         done
@@ -162,12 +159,10 @@ while IFS=$'\t' read -r PUZZLE_ID UNUSED_TICKET TITLE UNUSED_REST; do
         info "$PUZZLE_ID: no related issues found. Need to create a new issue: $TITLE"
 
         # These variables are needed for eval-ing ISSUE_BODY_TEMPLATE
-        # shellcheck disable=SC2034
         IFS=$'\t' read -r UNUSED_PUZZLE_ID ORIG_ISSUE UNUSED_TITLE PUZZLE_FILE PUZZLE_LINES < <(grep --max-count=1 "^$PUZZLE_ID" "$CODE_MAPPING_FILE")
 
         # "50-51" => {50, 51}
         # These variables are needed for eval-ing ISSUE_BODY_TEMPLATE
-        # shellcheck disable=SC2034
         IFS='-' read -r PUZZLE_LINE_START PUZZLE_LINE_END < <(echo "$PUZZLE_LINES")
 
         ISSUE_BODY="$(eval "$ISSUE_BODY_TEMPLATE")"

src/main/scripts/ci/pdd-xml-to-json.sh

@@ -15,7 +15,6 @@ if [ -z "${1:-}" ]; then
 fi
 
 # Yes, usage of `cat` is useless here, but it makes code more readable
-# shellcheck disable=SC2002
 cat "$1" \
 	| sed \
 		-e '/<?xml/d' \

src/main/scripts/execute-command.sh

@@ -51,16 +51,6 @@ case ${1:-} in
 			--batch-mode \
 			pmd:check
 		;;
-	'shellcheck')
-		# Shellcheck doesn't support recursive scanning: https://github.com/koalaman/shellcheck/issues/143
-		# Also I don't want to invoke it many times (slower, more code for handling failures), so I prefer this way.
-		# shellcheck disable=SC2207
-		SHELL_FILES=( $(find "$ROOTDIR/src/main/scripts" -type f -name '*.sh') )
-		exec shellcheck \
-			--shell bash \
-			--format gcc \
-			"${SHELL_FILES[@]}"
-		;;
 	'spotbugs')
 		exec "$MVN" \
 			--batch-mode \
@@ -86,7 +76,6 @@ case ${1:-} in
 		echo >&2 '- integration-tests'
 		echo >&2 '- jest'
 		echo >&2 '- pmd'
-		echo >&2 '- shellcheck'
 		echo >&2 '- spotbugs'
 		echo >&2 '- unit-tests'
 		exit 1

src/main/scripts/show-spring-boot-version-diff.sh

@@ -23,7 +23,6 @@ SPRING_POM="$(curl -sS --fail-with-body https://raw.githubusercontent.com/spring
 printf "Comparing with Spring Boot %s (project vs spring versions)\\n\\n" "$SPRING_VERSION"
 
 # I know about useless cat below, but it's here for better readability.
-# shellcheck disable=SC2002
 join \
 	<(cat "$PROJECT_POM" | awk -F'[<>]' -v OFS='\t' '$2~/\.version$/{print $2, $3}' | sort) \
 	<(echo "$SPRING_POM" | awk -F'[<>]' -v OFS='\t' '$2~/\.version$/{print $2, $3}' | sort) \