Skip to content

Issue with PatternStateHelper #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pserrer opened this issue Aug 15, 2017 · 2 comments
Closed

Issue with PatternStateHelper #120

pserrer opened this issue Aug 15, 2017 · 2 comments

Comments

@pserrer
Copy link

pserrer commented Aug 15, 2017

It seems, the PatternStateHelper has some issues and marks other patterns as inreview/inprogress, even if they aren't. Maybe there's an missing condition around the lines 59-72, which checks, for the correct lineage, but I'm not sure about this...

Thanks for your support
@nmercky
Copy link

nmercky commented Aug 15, 2017

Yes I made a pull request some months ago about this issue, you can check it here : #103

@pserrer
Copy link
Author

pserrer commented Aug 15, 2017

Already saw it and it seems, it works 👍

@sghoweri sghoweri mentioned this issue Oct 7, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmercky @pserrer