Skip to content

CLN remove _assert_not_frame_equal_both? #50393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Dec 22, 2022 · 5 comments · Fixed by #50394
Closed

CLN remove _assert_not_frame_equal_both? #50393

MarcoGorelli opened this issue Dec 22, 2022 · 5 comments · Fixed by #50394

Comments

@MarcoGorelli
Copy link
Member

Doesn't look like this is used anywhere

def _assert_not_frame_equal_both(a, b, **kwargs):
"""
Check that two DataFrame are not equal.
This check is performed commutatively.
Parameters
----------
a : DataFrame
The first DataFrame to compare.
b : DataFrame
The second DataFrame to compare.
kwargs : dict
The arguments passed to `tm.assert_frame_equal`.
"""
_assert_not_frame_equal(a, b, **kwargs)
_assert_not_frame_equal(b, a, **kwargs)

@MarcoGorelli
Copy link
Member Author

Same with

def curpath():
pth, _ = os.path.split(os.path.abspath(__file__))
return pth

@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Dec 22, 2022

this one too

def _check_cast(df, v):
"""
Check if all dtypes of df are equal to v
"""
assert all(s.dtype.name == v for _, s in df.items())

EDIT my bad, not this one

@ShashwatAgrawal20
Copy link
Contributor

take

@ShashwatAgrawal20
Copy link
Contributor

Hey @MarcoGorelli should these functions be directly removed ?

@MarcoGorelli
Copy link
Member Author

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants