Skip to content

REF: Define ops on Resampler as normal methods #49001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Oct 7, 2022 · 4 comments · Fixed by #50913
Closed

REF: Define ops on Resampler as normal methods #49001

rhshadrach opened this issue Oct 7, 2022 · 4 comments · Fixed by #50913
Labels
Clean Refactor Internal refactoring of code Resample resample method

Comments

@rhshadrach
Copy link
Member

Ref: #48980 (review)

Similar to #48400 with groupby, we should define methods on the Resampler class rather than setting them as attributes after the class definition. While this involves a little more boilerplate code, it is more straightforward to understand and easier to enhance or extend.
@rhshadrach rhshadrach added Refactor Internal refactoring of code Resample resample method Clean labels Oct 7, 2022
@rhshadrach rhshadrach added this to the Contributions Welcome milestone Oct 7, 2022
@erikcek
Copy link

erikcek commented Oct 8, 2022

take

@erikcek erikcek removed their assignment Oct 8, 2022
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@Pvlb1998
Copy link

Is this issue still possible do Take?

@rhshadrach
Copy link
Member Author

rhshadrach commented Oct 20, 2022 •
edited
Loading

@Pvlb1998 - yes, comment take and it will be assigned to you.

@lucaslarios
Copy link

hello, could you specify a little better the purpose of the issue? in which file is this class found? Is there any solution suggestion?

@rhshadrach rhshadrach mentioned this issue Dec 1, 2022
Open
@mroeschke mroeschke mentioned this issue Jan 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Refactor Internal refactoring of code Resample resample method
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: Define methods on resample non-dynamically mroeschke/pandas
5 participants
@mroeschke @erikcek @rhshadrach @lucaslarios @Pvlb1998