-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: use oldest-supported-numpy in pyproject.toml #43141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we already do this - i suppose it needs updating for 3.10 |
I think the proposal is to replace Lines 8 to 19 in 5410fb7
"oldest-supported-numpy" , which will keep things up to date for us. That sounds great to me.
|
Duplicate of #40307. |
I searched for the string
Yes, it was.
That was the point (and this is something in this issue not in the issue from 6 months ago), the current list needs updating, but instead of continually updating it, it's better to just take |
Is your feature request related to a problem?
Currently using Pandas on Python 3.10 RC 1 gets the wrong version of numpy (1.19) and builds the wheel manually, instead of getting the first wheel for NumPy + Python 3.10 (1.21).
Describe the solution you'd like
This problem has already been solved by https://github.com/scipy/oldest-supported-numpy/blob/master/setup.cfg - by using SciPy (the org, not the package)'s oldest-supported-numpy, you get a thorough and up-to-date listing of the oldest supported numpy's for compiling. You can further control it using normal requirements (such as setting a higher requirement for some version, etc). That's literally all the package does, and is maintained by NumPy maintainers.
API breaking implications
None, just a build improvement.
Describe alternatives you've considered
Otherwise, the contents of https://github.com/scipy/oldest-supported-numpy/blob/master/setup.cfg should be placed in pyproject.toml and maintained for each new Python release - 3.10 is currently missing.
Additional context
Before:
After:
"oldest-supported-numpy"
(Optionally pinned if you want)
The text was updated successfully, but these errors were encountered: