Enable Pylint warning consider-using-ternary (#51051)

* Enable the Pylint check "consider-using-ternary"

* Reformat file

* Fix error in ternary statement

---------

Co-authored-by: Marco Edward Gorelli <[email protected]>

Author: uzzell

pandas/core/algorithms.py

@@ -1197,8 +1197,10 @@ def is_valid_dtype_n_method(dtype: DtypeObj) -> bool:
         nsmallest/nlargest methods
         """
         return (
-            is_numeric_dtype(dtype) and not is_complex_dtype(dtype)
-        ) or needs_i8_conversion(dtype)
+            not is_complex_dtype(dtype)
+            if is_numeric_dtype(dtype)
+            else needs_i8_conversion(dtype)
+        )
 
 
 class SelectNSeries(SelectN):

pandas/io/stata.py

@@ -1221,7 +1221,7 @@ def _read_new_header(self) -> None:
             raise ValueError(_version_error.format(version=self.format_version))
         self._set_encoding()
         self.path_or_buf.read(21)  # </release><byteorder>
-        self.byteorder = self.path_or_buf.read(3) == b"MSF" and ">" or "<"
+        self.byteorder = ">" if self.path_or_buf.read(3) == b"MSF" else "<"
         self.path_or_buf.read(15)  # </byteorder><K>
         nvar_type = "H" if self.format_version <= 118 else "I"
         nvar_size = 2 if self.format_version <= 118 else 4
@@ -1413,7 +1413,7 @@ def _read_old_header(self, first_char: bytes) -> None:
             raise ValueError(_version_error.format(version=self.format_version))
         self._set_encoding()
         self.byteorder = (
-            struct.unpack("b", self.path_or_buf.read(1))[0] == 0x1 and ">" or "<"
+            ">" if struct.unpack("b", self.path_or_buf.read(1))[0] == 0x1 else "<"
         )
         self.filetype = struct.unpack("b", self.path_or_buf.read(1))[0]
         self.path_or_buf.read(1)  # unused

pyproject.toml

@@ -314,7 +314,6 @@ disable = [
   "unnecessary-lambda-assignment",
 
   # pylint type "R": refactor, for bad code smell
-  "consider-using-ternary",
   "consider-using-with",
   "cyclic-import",
   "duplicate-code",