Rewritten functions using ES6 style

Author: ismailuddin

doc/source/_static/js/whatsnew_links.js

@@ -1,32 +1,22 @@
 (function() {
-	const links = document.getElementsByTagName('a');
-	for (let i = 0; i < links.length; i++) {
+	/* Reformats last part of 'whatsnew' URLs */
+	const generateWhatsNew = (whatsNew) => {
+		let url = whatsNew[0], anchor = whatsNew[1];
+		url = ((url) => url.split(".")[0] + "/")(url);
+		let anchorEls = anchor.slice(9).split("-");
+		anchorEls[0] = ((version) => "v" + version.slice(0,1) + "." + version.slice(1,-1) + "." + version.slice(-1) + ".html#")(anchorEls[0]);
+		return url + anchorEls[0] + anchorEls.slice(1).join("-");
+	}
+
+	const links = Array.from(document.getElementsByTagName("a"));
+	links.forEach((link) => {
 		const re = /(whatsnew.html)#(whatsnew)-[\d]+(-\w+)+/g;
-		let linkElements = links[i].href.split("/");		
+		let linkElements = link.href.split("/");		
 		if (re.test(linkElements.slice(-1)[0])) {
 			let whatsNew = linkElements.slice(-1)[0].split("#");
 			whatsNew = generateWhatsNew(whatsNew);
 			linkElements[linkElements.length - 1] = whatsNew;
-			links[i].href = linkElements.join("/")
+			link.href = linkElements.join("/")
 		}
-	}
-	/* Reformats last part of 'whatsnew' URLs */
-	function generateWhatsNew(whatsNew) {
-		let url = whatsNew[0];
-		let anchor = whatsNew[1];
-		url = replaceURL(url);
-		let anchorEls = anchor.slice(9).split("-");
-		anchorEls[0] = reformatVersion(anchorEls[0]);
-		return url + anchorEls[0] + anchorEls.slice(1).join("-");
-	}
-
-    /* Replaces 'whatsnew.html' with 'whatsnew/' */
-	function replaceURL(url) {
-		return url.split(".")[0] + "/"
-	}
-
-    /* Converts version number into vX.X.X */
-	function reformatVersion(version) {
-		return "v" + version.slice(0,1) + "." + version.slice(1,-1) + "." + version.slice(-1) + ".html#"
-	}
-})();
+	});
+})();

doc/source/conf.py

@@ -657,3 +657,4 @@ def setup(app):
     app.add_autodocumenter(AccessorMethodDocumenter)
     app.add_autodocumenter(AccessorCallableDocumenter)
     app.add_directive('autosummary', PandasAutosummary)
+    app.add_js('js/whatsnew_links.js')

doc/source/themes/nature_with_gtoc/layout.html

@@ -105,5 +105,4 @@ <h3 style="margin-top: 1.5em;">{{ _('Search') }}</h3>
     var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
   })();
 </script>
-<script type="text/javascript" src="./_static/js/whatsnew_links.js"></script>
 {% endblock %}