Skip to content

CLEAN: Fix up Groupby classes #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dr-Irv opened this issue Jul 18, 2022 · 0 comments · Fixed by #166
Closed

CLEAN: Fix up Groupby classes #149

Dr-Irv opened this issue Jul 18, 2022 · 0 comments · Fixed by #166
Labels
Clean Groupby

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jul 18, 2022 •
edited
Loading

In pandas 1.1., the classes were _GroupBy and Groupby. Since that time, _Groupby was replaced by BaseGroupBy, and generics were introduced.

The original version of these stubs were generated on top of pandas 1.1.

This should get reconciled at some point so the class names are the same, including the various subclassing that is going on.

In pandas, BaseGroupBy inherits from SelectionMixin[NDFrameT], but if that is used in the stubs, mypy complains because the definitions of aggregate() are different in SelectionMixin and GroupBy

So there is some work to do here.

See #142 and #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLEAN: Align Groupby types Dr-Irv/pandas-stubs
1 participant
@Dr-Irv