Skip to content

Search results du(tri)plicated after reindex since 1.1-rc39 #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dobrou opened this issue Sep 14, 2018 · 4 comments
Closed

Search results du(tri)plicated after reindex since 1.1-rc39 #2355

dobrou opened this issue Sep 14, 2018 · 4 comments
Assignees
Milestone

Comments

@dobrou
Copy link
Contributor

dobrou commented Sep 14, 2018

Steps to reproduce:

  1. Completely clean the index database and start first indexing
  2. Search results are OK
  3. Run reindex
  4. Search results are duplicated
  5. Every next reindex adds duplicate entries. See attached screenshot after second reindex run.
    In indexer it's visible it adds all files as new each time.

image

Env: Windows, Tomcat, JRE 10.0.2, indexing GIT repositories, Opengrok 1.1-rc39
Opengrok 1.1-rc38 is OK.

My indexer commandline:
java -Xmx5048m -Xms512m --add-modules java.xml.bind -jar .\bin\opengrok-current\lib\opengrok.jar --history -U "http://opengrok/" -R .\configuration-default.xml -W .\configuration-git.xml -P -S -v -s .\sources\git -d .\index\git -p __all__

My xml config:

<?xml version="1.0" encoding="UTF-8"?>
<java version="9.0.1" class="java.beans.XMLDecoder">
 <object class="org.opengrok.indexer.configuration.Configuration" id="Configuration0">
  <void property="groupsCollapseThreshold"><int>0</int></void>
  <void property="hitsPerPage"><int>50</int></void>
  <void property="allowLeadingWildcard"><boolean>true</boolean></void>
  <void property="projectsEnabled"><boolean>true</boolean></void>
  <void property="historyCache"><boolean>false</boolean></void>
  <void property="historyEnabled"><boolean>true</boolean></void>
  <void property="generateHtml"><boolean>false</boolean></void>
  <void property="quickContextScan"><boolean>false</boolean></void>
  <void property="optimizeDatabase"><boolean>true</boolean></void>
  <void property="cmds">
   <object class="java.util.Collections" method="unmodifiableMap">
    <object class="java.util.HashMap">
     <void method="put">
      <string>org.opengrok.indexer.history.GitRepository</string>
      <string>git</string>
     </void>
    </object>
   </object>
  </void>
  <void property="ctags">
   <string>.\bin\ctags-current\ctags.exe</string>
  </void>
  <void property="remoteScmSupported">
   <object class="java.lang.Enum" method="valueOf">
    <class>org.opengrok.indexer.configuration.Configuration$RemoteSCM</class>
    <string>OFF</string>
   </object>
  </void>
 </object>
</java>
@vladak
Copy link
Member

vladak commented Sep 26, 2018

Seems like some of the Windows fixes broke this. Maybe we can wait for #2335 to be fixed and see if it resolves this problem as well.

@tarzanek
Copy link
Contributor

well yes, uuid is not generated properly now, so lookup will fail and indexer adds new records

@tarzanek tarzanek added this to the 1.1 milestone Sep 27, 2018
@tarzanek
Copy link
Contributor

tarzanek commented Sep 27, 2018

I will fix this as part of push for #2335, hence closing

@tarzanek tarzanek self-assigned this Sep 27, 2018
@dobrou
Copy link
Contributor Author

dobrou commented Sep 27, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants