[FSSDK-10586] rollout experiment key returns wrong decision (#949)

Author: junaed-optimizely

lib/core/decision_service/index.tests.js

@@ -1679,6 +1679,7 @@ describe('lib/core/decision_service', function() {
                 status: 'Not started',
                 key: '594031',
                 id: '594031',
+                isRollout: true,
                 variations: [
                   {
                     id: '594032',
@@ -1816,6 +1817,7 @@ describe('lib/core/decision_service', function() {
                 status: 'Not started',
                 key: '594037',
                 id: '594037',
+                isRollout: true,
                 variations: [
                   {
                     id: '594038',
@@ -2000,6 +2002,7 @@ describe('lib/core/decision_service', function() {
                 status: 'Not started',
                 key: '594037',
                 id: '594037',
+                isRollout: true,
                 variations: [
                   {
                     id: '594038',
@@ -2154,6 +2157,7 @@ describe('lib/core/decision_service', function() {
               layerId: '599055',
               forcedVariations: {},
               audienceIds: [],
+              isRollout: true,
               variations: [
                 {
                   key: '599057',

lib/optimizely/index.ts

@@ -489,7 +489,7 @@ export default class Optimizely implements Client {
         }
 
         const experiment = configObj.experimentKeyMap[experimentKey];
-        if (!experiment) {
+        if (!experiment || experiment.isRollout) {
           this.logger.log(LOG_LEVEL.DEBUG, ERROR_MESSAGES.INVALID_EXPERIMENT_KEY, MODULE_NAME, experimentKey);
           return null;
         }

lib/project_config/project_config.ts

@@ -166,6 +166,7 @@ export const createProjectConfig = function(datafileObj?: JSON, datafileStr: str
   projectConfig.rolloutIdMap = keyBy(projectConfig.rollouts || [], 'id');
   objectValues(projectConfig.rolloutIdMap || {}).forEach(rollout => {
     (rollout.experiments || []).forEach(experiment => {
+      experiment.isRollout = true
       projectConfig.experiments.push(experiment);
       // Creates { <variationKey>: <variation> } map inside of the experiment
       experiment.variationKeyMap = keyBy(experiment.variations, 'key');

lib/shared_types.ts

@@ -171,6 +171,7 @@ export interface Experiment {
   audienceIds: string[];
   trafficAllocation: TrafficAllocation[];
   forcedVariations?: { [key: string]: string };
+  isRollout?: boolean;
 }
 
 export enum VariableType {

lib/tests/test_data.ts

@@ -1649,6 +1649,7 @@ export var datafileWithFeaturesExpectedData = {
           status: 'Not started',
           key: '599056',
           id: '599056',
+          isRollout: true,
           variationKeyMap: {
             599057: {
               key: '599057',
@@ -1713,6 +1714,7 @@ export var datafileWithFeaturesExpectedData = {
           ],
           key: '594031',
           id: '594031',
+          isRollout: true,
           variationKeyMap: {
             594032: {
               variables: [
@@ -1785,6 +1787,7 @@ export var datafileWithFeaturesExpectedData = {
           ],
           key: '594037',
           id: '594037',
+          isRollout: true,
           variationKeyMap: {
             594038: {
               variables: [
@@ -1858,6 +1861,7 @@ export var datafileWithFeaturesExpectedData = {
           ],
           key: '594060',
           id: '594060',
+          isRollout: true,
           variationKeyMap: {
             594061: {
               variables: [
@@ -1922,6 +1926,7 @@ export var datafileWithFeaturesExpectedData = {
           ],
           key: '594066',
           id: '594066',
+          isRollout: true,
           variationKeyMap: {
             594067: {
               variables: [