Skip to content

Commit 9be4469

Browse files
author
Hussein Jafferjee
committed
decode value
1 parent 14a4832 commit 9be4469

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

sdk/lib/opentelemetry/sdk/resources/resource.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7+
require 'uri'
8+
79
module OpenTelemetry
810
module SDK
911
module Resources
@@ -46,7 +48,7 @@ def telemetry_sdk
4648

4749
resource_pairs.split(',').each do |pair|
4850
key, value = pair.split('=')
49-
resource_attributes[key.strip] = value
51+
resource_attributes[key.strip] = URI.decode_www_form_component(value).strip
5052
end
5153

5254
resource_attributes.delete_if { |_key, value| value.nil? || value.empty? }

sdk/test/opentelemetry/sdk/configurator_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
end
9090

9191
it 'cleans up whitespace in user provided resources' do
92-
OpenTelemetry::TestHelpers.with_env('OTEL_RESOURCE_ATTRIBUTES' => 'important_foo=x, important_bar=y') do
92+
OpenTelemetry::TestHelpers.with_env('OTEL_RESOURCE_ATTRIBUTES' => ' important_foo=x, important_bar=y ') do
9393
configurator.resource = OpenTelemetry::SDK::Resources::Resource.create()
9494
_(configurator_resource_attributes).must_equal(default_resource_attributes.merge('important_foo' => 'x', 'important_bar' => 'y'))
9595
end

0 commit comments

Comments
 (0)