Skip to content

tip: true on the linearRegression mark #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fil opened this issue Aug 27, 2023 · 2 comments
Open

tip: true on the linearRegression mark #1840

Fil opened this issue Aug 27, 2023 · 2 comments
Labels
enhancement New feature or request question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented Aug 27, 2023

The tip on the linearRegression mark is also a bit chaotic (#1835), since it points at invisible dots. I don't see why someone would activate it on that mark, though, but an idea might be to display information about R2 (?). Though probably we should just drop the option? Doing nothing is probably fine too?

@Fil Fil added enhancement New feature or request question Further information is needed labels Aug 27, 2023
@jheer
Copy link

jheer commented Mar 20, 2024

I find the current behavior rather confusing. Doing nothing (and perhaps including a console warning?) for tip: true might be preferable. Even better options might include providing tips for "sample" points along the regression line, showing the current predictor value alongside predicted regression values and (if visible) +/- error values. The existing tip behavior for area marks is already pretty close to this. The R^2 value would also be nice, but probably not absolutely necessary.

@Fil
Copy link
Contributor Author

Fil commented Mar 20, 2024

A particular difficulty is that the regression is computed in screen space, which is equivalent (visually) for linear scales, and makes the mark work well with log scales etc; however it doesn't make it easy to derive predicted values. I also think we should do nothing and issue a warning — this would be better than the current behavior in any case. (And leave the door open if someone has a better idea in the future.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is needed
Projects
None yet
Development

No branches or pull requests

2 participants