Skip to content

Should the group transform special-case date keys? #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbostock opened this issue Feb 24, 2021 · 1 comment
Closed

Should the group transform special-case date keys? #169

mbostock opened this issue Feb 24, 2021 · 1 comment

Comments

@mbostock
Copy link
Member

A line’s stroke or z cannot be specified as a Date, because each Date is a distinct object, and thus every datum is put in a distinct group. (I think no is the answer is because the SameValueZero algorithm is strong precedent.)
@mbostock
Copy link
Member Author

d3.groups now uses InternMap so this should no longer be an issue.

@Fil Fil mentioned this issue Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock