Skip to content

Commit 70ee172

Browse files
authored
fix crash during reindex (#2028)
1 parent 4422636 commit 70ee172

File tree

4 files changed

+170
-1
lines changed

4 files changed

+170
-1
lines changed

src/options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function valueof(data, value, type) {
2525
}
2626

2727
function maybeTake(values, index) {
28-
return index ? take(values, index) : values;
28+
return values != null && index ? take(values, index) : values;
2929
}
3030

3131
function maybeTypedMap(data, f, type) {

test/output/mixedFacets.svg

Lines changed: 148 additions & 0 deletions
Loading

test/plots/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ export * from "./metro-unemployment-ridgeline.js";
164164
export * from "./metro-unemployment-slope.js";
165165
export * from "./metro-unemployment-stroke.js";
166166
export * from "./metro-unemployment.js";
167+
export * from "./mixed-facets.js";
167168
export * from "./moby-dick-faceted.js";
168169
export * from "./moby-dick-letter-frequency.js";
169170
export * from "./moby-dick-letter-pairs.js";

test/plots/mixed-facets.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import * as Plot from "@observablehq/plot";
2+
3+
export async function mixedFacets() {
4+
const data = [
5+
{date: new Date("2024-01-01"), name: "a", value: 1},
6+
{date: new Date("2024-01-01"), name: "b", value: 2},
7+
{date: new Date("2024-01-01"), name: "a", value: 2},
8+
{date: new Date("2024-02-01"), name: "b", value: 3},
9+
{date: new Date("2024-02-01"), name: "a", value: 5},
10+
{date: new Date("2024-02-01"), name: "b", value: 2},
11+
{date: new Date("2024-02-01"), name: "a", value: 3}
12+
];
13+
return Plot.plot({
14+
marks: [
15+
Plot.barY(data, {x: "name", y: "value", fill: "name", fx: "date", fy: "name"}),
16+
Plot.barY(data, {x: "name", y: "value", fx: "date", stroke: "currentColor"}),
17+
Plot.ruleY([0])
18+
]
19+
});
20+
}

0 commit comments

Comments
 (0)