Skip to content

Commit d74bda4

Browse files
lpincamarco-ippolito
authored andcommitted
test: add AbortController to knownGlobals
PR-URL: #53020 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent 68fcbb6 commit d74bda4

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

test/common/index.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,7 @@ function platformTimeout(ms) {
280280
}
281281

282282
let knownGlobals = [
283+
AbortController,
283284
atob,
284285
btoa,
285286
clearImmediate,
@@ -292,15 +293,6 @@ let knownGlobals = [
292293
queueMicrotask,
293294
];
294295

295-
// TODO(@jasnell): This check can be temporary. AbortController is
296-
// not currently supported in either Node.js 12 or 10, making it
297-
// difficult to run tests comparatively on those versions. Once
298-
// all supported versions have AbortController as a global, this
299-
// check can be removed and AbortController can be added to the
300-
// knownGlobals list above.
301-
if (global.AbortController)
302-
knownGlobals.push(global.AbortController);
303-
304296
if (global.gc) {
305297
knownGlobals.push(global.gc);
306298
}

0 commit comments

Comments
 (0)