test_runner: update kPatterns

PR-URL: #54728
Fixes: #54726
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

Author: pmarchini

lib/internal/test_runner/utils.js

@@ -51,7 +51,7 @@ const coverageColors = {
 const kMultipleCallbackInvocations = 'multipleCallbackInvocations';
 const kRegExpPattern = /^\/(.*)\/([a-z]*)$/;
 
-const kPatterns = ['test', 'test/**/*', 'test-*', '*[.-_]test'];
+const kPatterns = ['test', 'test/**/*', 'test-*', '*[._-]test'];
 const kDefaultPattern = `**/{${ArrayPrototypeJoin(kPatterns, ',')}}.?(c|m)js`;
 
 

test/fixtures/test-runner/issue-54726/latest.js

@@ -0,0 +1,4 @@
+'use strict';
+const test = require('node:test');
+
+test('this should pass');

test/fixtures/test-runner/issue-54726/non-matching.js

@@ -0,0 +1,4 @@
+'use strict';
+const test = require('node:test');
+
+test('this should pass');

test/fixtures/test-runner/matching-patterns/index-test.cjs

@@ -0,0 +1,4 @@
+'use strict';
+import test from 'node:test';
+
+test('this should pass');

test/fixtures/test-runner/matching-patterns/index-test.js

@@ -43,6 +43,22 @@ for (const isolation of ['none', 'process']) {
     assert.match(stdout, /ok 6 - this should be executed/);
   }
 
+  {
+    // Should match files with "-test.(c|m)js" suffix.
+    const args = ['--test', '--test-reporter=tap',
+                  `--experimental-test-isolation=${isolation}`];
+    const child = spawnSync(process.execPath, args, { cwd: join(testFixtures, 'matching-patterns') });
+
+    assert.strictEqual(child.status, 0);
+    assert.strictEqual(child.signal, null);
+    assert.strictEqual(child.stderr.toString(), '');
+    const stdout = child.stdout.toString();
+
+    assert.match(stdout, /ok 1 - this should pass/);
+    assert.match(stdout, /ok 2 - this should pass/);
+    assert.match(stdout, /ok 3 - this should pass/);
+  }
+
   {
     // Same but with a prototype mutation in require scripts.
     const args = [
@@ -361,3 +377,22 @@ for (const isolation of ['none', 'process']) {
   assert.match(stdout, /# fail 0/);
   assert.match(stdout, /# skipped 0/);
 }
+
+{
+  // Should not match files like latest.js
+  const args = ['--test', '--test-reporter=tap'];
+  const child = spawnSync(process.execPath, args, { cwd: join(testFixtures, 'issue-54726') });
+
+  assert.strictEqual(child.status, 0);
+  assert.strictEqual(child.signal, null);
+  assert.strictEqual(child.stderr.toString(), '');
+  const stdout = child.stdout.toString();
+
+  assert.match(stdout, /tests 0/);
+  assert.match(stdout, /suites 0/);
+  assert.match(stdout, /pass 0/);
+  assert.match(stdout, /fail 0/);
+  assert.match(stdout, /cancelled 0/);
+  assert.match(stdout, /skipped 0/);
+  assert.match(stdout, /todo 0/);
+}