Skip to content

Commit 5961253

Browse files
richardlautargos
authored andcommitted
src: remove base64 from process.versions
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: #52714 PR-URL: #53442 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
1 parent 11dd15c commit 5961253

File tree

4 files changed

+1
-11
lines changed

4 files changed

+1
-11
lines changed

src/base64_version.h

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/node_metadata.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#include "acorn_version.h"
33
#include "ada.h"
44
#include "ares.h"
5-
#include "base64_version.h"
65
#include "brotli/encode.h"
76
#include "cjs_module_lexer_version.h"
87
#include "llhttp.h"
@@ -112,7 +111,6 @@ Metadata::Versions::Versions() {
112111

113112
acorn = ACORN_VERSION;
114113
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
115-
base64 = BASE64_VERSION;
116114
uvwasi = UVWASI_VERSION_STRING;
117115

118116
#if HAVE_OPENSSL

src/node_metadata.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ namespace node {
5050
V(simdutf) \
5151
V(ada) \
5252
NODE_VERSIONS_KEY_UNDICI(V) \
53-
V(cjs_module_lexer) \
54-
V(base64)
53+
V(cjs_module_lexer)
5554

5655
#if HAVE_OPENSSL
5756
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)

test/parallel/test-process-versions.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ const expected_keys = [
2222
'simdutf',
2323
'ada',
2424
'cjs_module_lexer',
25-
'base64',
2625
];
2726

2827
const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');

0 commit comments

Comments
 (0)